{"schema":"libjg2-1", "vpath":"/git/", "avatar":"/git/avatar/", "alang":"", "gen_ut":1758481138, "reponame":"openssl", "desc":"OpenSSL", "owner": { "name": "Andy Green", "email": "andy@warmcat.com", "md5": "c50933ca2aa61e0fe2c43d46bb6b59cb" },"url":"https://warmcat.com/repo/openssl", "f":3, "items": [ {"schema":"libjg2-1", "cid":"59456c4798ccf5fd5ae081c7c8623cae", "commit": {"type":"commit", "time": 1472650456, "time_ofs": 18446744073709551376, "oid_tree": { "oid": "47c66a6223d6529132018e8a514a894dfedfa9fd", "alias": []}, "oid":{ "oid": "bde588df8a4d9f714cefe9cfd1a3931558de4c3c", "alias": []}, "msg": "Code cleanup UI", "sig_commit": { "git_time": { "time": 1472650456, "offset": -240 }, "name": "Rich Salz", "email": "rsalz@openssl.org", "md5": "3ed6b9cf7bbe83902a044f6590346d26" }, "sig_author": { "git_time": { "time": 1472578278, "offset": -240 }, "name": "Rich Salz", "email": "rsalz@openssl.org", "md5": "3ed6b9cf7bbe83902a044f6590346d26" }}, "body": "Code cleanup UI\n\nRemove NULL check on parameter, and use NULL not ! on buffer.\n\nReviewed-by: Richard Levitte \u003clevitte@openssl.org\u003e\n" , "diff": "diff --git a/crypto/ui/ui_lib.c b/crypto/ui/ui_lib.c\nindex 8992ae7..004aeb0 100644\n--- a/crypto/ui/ui_lib.c\n+++ b/crypto/ui/ui_lib.c\n@@ -670,29 +670,21 @@ char *(*UI_method_get_prompt_constructor(UI_METHOD *method)) (UI *,\n \n enum UI_string_types UI_get_string_type(UI_STRING *uis)\n {\n- if (!uis)\n- return UIT_NONE;\n return uis-\u003etype;\n }\n \n int UI_get_input_flags(UI_STRING *uis)\n {\n- if (!uis)\n- return 0;\n return uis-\u003einput_flags;\n }\n \n const char *UI_get0_output_string(UI_STRING *uis)\n {\n- if (!uis)\n- return NULL;\n return uis-\u003eout_string;\n }\n \n const char *UI_get0_action_string(UI_STRING *uis)\n {\n- if (!uis)\n- return NULL;\n switch (uis-\u003etype) {\n case UIT_PROMPT:\n case UIT_BOOLEAN:\n@@ -704,8 +696,6 @@ const char *UI_get0_action_string(UI_STRING *uis)\n \n const char *UI_get0_result_string(UI_STRING *uis)\n {\n- if (!uis)\n- return NULL;\n switch (uis-\u003etype) {\n case UIT_PROMPT:\n case UIT_VERIFY:\n@@ -717,8 +707,6 @@ const char *UI_get0_result_string(UI_STRING *uis)\n \n const char *UI_get0_test_string(UI_STRING *uis)\n {\n- if (!uis)\n- return NULL;\n switch (uis-\u003etype) {\n case UIT_VERIFY:\n return uis-\u003e_.string_data.test_buf;\n@@ -729,8 +717,6 @@ const char *UI_get0_test_string(UI_STRING *uis)\n \n int UI_get_result_minsize(UI_STRING *uis)\n {\n- if (!uis)\n- return -1;\n switch (uis-\u003etype) {\n case UIT_PROMPT:\n case UIT_VERIFY:\n@@ -742,8 +728,6 @@ int UI_get_result_minsize(UI_STRING *uis)\n \n int UI_get_result_maxsize(UI_STRING *uis)\n {\n- if (!uis)\n- return -1;\n switch (uis-\u003etype) {\n case UIT_PROMPT:\n case UIT_VERIFY:\n@@ -759,8 +743,6 @@ int UI_set_result(UI *ui, UI_STRING *uis, const char *result)\n \n ui-\u003eflags \u0026\u003d ~UI_FLAG_REDOABLE;\n \n- if (!uis)\n- return -1;\n switch (uis-\u003etype) {\n case UIT_PROMPT:\n case UIT_VERIFY:\n@@ -789,7 +771,7 @@ int UI_set_result(UI *ui, UI_STRING *uis, const char *result)\n }\n }\n \n- if (!uis-\u003eresult_buf) {\n+ if (uis-\u003eresult_buf \u003d\u003d NULL) {\n UIerr(UI_F_UI_SET_RESULT, UI_R_NO_RESULT_BUFFER);\n return -1;\n }\n@@ -801,7 +783,7 @@ int UI_set_result(UI *ui, UI_STRING *uis, const char *result)\n {\n const char *p;\n \n- if (!uis-\u003eresult_buf) {\n+ if (uis-\u003eresult_buf \u003d\u003d NULL) {\n UIerr(UI_F_UI_SET_RESULT, UI_R_NO_RESULT_BUFFER);\n return -1;\n }\n","s":{"c":1758481138,"u": 13293}} ],"g": 14121,"chitpc": 0,"ehitpc": 0,"indexed":0 , "ab": 0, "si": 0, "db":0, "di":0, "sat":0, "lfc": "0000"}