{"schema":"libjg2-1", "vpath":"/git/", "avatar":"/git/avatar/", "alang":"", "gen_ut":1754240631, "reponame":"openssl", "desc":"OpenSSL", "owner": { "name": "Andy Green", "email": "andy@warmcat.com", "md5": "c50933ca2aa61e0fe2c43d46bb6b59cb" },"url":"https://warmcat.com/repo/openssl", "f":3, "items": [ {"schema":"libjg2-1", "cid":"874191126bf1c13bdf81bfcb5bfead54", "commit": {"type":"commit", "time": 1471439575, "time_ofs": 60, "oid_tree": { "oid": "3f0d1dc1a57bae07f1806c27c31e96a900c5e48a", "alias": []}, "oid":{ "oid": "8adc1cb8510a9f4beab9e53f53c9690d2ced12fd", "alias": []}, "msg": "Constify X509_get0_signature()", "sig_commit": { "git_time": { "time": 1471439575, "offset": 60 }, "name": "Dr. Stephen Henson", "email": "steve@openssl.org", "md5": "fb4026c8240f7577a612418c24e54343" }, "sig_author": { "git_time": { "time": 1471439452, "offset": 60 }, "name": "Dr. Stephen Henson", "email": "steve@openssl.org", "md5": "fb4026c8240f7577a612418c24e54343" }}, "body": "Constify X509_get0_signature()\n\nReviewed-by: Richard Levitte \u003clevitte@openssl.org\u003e\n" , "diff": "diff --git a/apps/x509.c b/apps/x509.c\nindex 27a928c..6f72f82 100644\n--- a/apps/x509.c\n+++ b/apps/x509.c\n@@ -604,7 +604,8 @@ int x509_main(int argc, char **argv)\n }\n \n if (badsig) {\n- ASN1_BIT_STRING *signature;\n+ const ASN1_BIT_STRING *signature;\n+\n X509_get0_signature(\u0026signature, NULL, x);\n corrupt_signature(signature);\n }\ndiff --git a/crypto/x509/t_x509.c b/crypto/x509/t_x509.c\nindex bfd6f6d..5d7c130 100644\n--- a/crypto/x509/t_x509.c\n+++ b/crypto/x509/t_x509.c\n@@ -191,8 +191,8 @@ int X509_print_ex(BIO *bp, X509 *x, unsigned long nmflags,\n X509_get0_extensions(x), cflag, 8);\n \n if (!(cflag \u0026 X509_FLAG_NO_SIGDUMP)) {\n- X509_ALGOR *sig_alg;\n- ASN1_BIT_STRING *sig;\n+ const X509_ALGOR *sig_alg;\n+ const ASN1_BIT_STRING *sig;\n X509_get0_signature(\u0026sig, \u0026sig_alg, x);\n if (X509_signature_print(bp, sig_alg, sig) \u003c\u003d 0)\n goto err;\ndiff --git a/crypto/x509/x_x509.c b/crypto/x509/x_x509.c\nindex 7d9f981..6783fd8 100644\n--- a/crypto/x509/x_x509.c\n+++ b/crypto/x509/x_x509.c\n@@ -209,7 +209,8 @@ int i2d_re_X509_tbs(X509 *x, unsigned char **pp)\n return i2d_X509_CINF(\u0026x-\u003ecert_info, pp);\n }\n \n-void X509_get0_signature(ASN1_BIT_STRING **psig, X509_ALGOR **palg, X509 *x)\n+void X509_get0_signature(const ASN1_BIT_STRING **psig,\n+ const X509_ALGOR **palg, const X509 *x)\n {\n if (psig)\n *psig \u003d \u0026x-\u003esignature;\ndiff --git a/doc/crypto/X509_get0_signature.pod b/doc/crypto/X509_get0_signature.pod\nindex 86b0b40..0741dfb 100644\n--- a/doc/crypto/X509_get0_signature.pod\n+++ b/doc/crypto/X509_get0_signature.pod\n@@ -10,7 +10,8 @@ X509_CRL_get_signature_nid - signature information\n \n #include \u003copenssl/x509.h\u003e\n \n- void X509_get0_signature(ASN1_BIT_STRING **psig, X509_ALGOR **palg,\n+ void X509_get0_signature(const ASN1_BIT_STRING **psig,\n+ const X509_ALGOR **palg,\n const X509 *x);\n int X509_get_signature_nid(const X509 *x);\n const X509_ALGOR *X509_get0_tbs_sigalg(const X509 *x);\ndiff --git a/include/openssl/x509.h b/include/openssl/x509.h\nindex 7e649eb..fc23d9b 100644\n--- a/include/openssl/x509.h\n+++ b/include/openssl/x509.h\n@@ -548,7 +548,8 @@ X509 *d2i_X509_AUX(X509 **a, const unsigned char **pp, long length);\n \n int i2d_re_X509_tbs(X509 *x, unsigned char **pp);\n \n-void X509_get0_signature(ASN1_BIT_STRING **psig, X509_ALGOR **palg, X509 *x);\n+void X509_get0_signature(const ASN1_BIT_STRING **psig,\n+ const X509_ALGOR **palg, const X509 *x);\n int X509_get_signature_nid(const X509 *x);\n \n int X509_trusted(const X509 *x);\n","s":{"c":1754240631,"u": 12075}} ],"g": 12643,"chitpc": 0,"ehitpc": 0,"indexed":0 , "ab": 0, "si": 0, "db":0, "di":0, "sat":0, "lfc": "0000"}