{"schema":"libjg2-1",
"vpath":"/git/",
"avatar":"/git/avatar/",
"alang":"",
"gen_ut":1752058148,
"reponame":"openssl",
"desc":"OpenSSL",
"owner": { "name": "Andy Green", "email": "andy@warmcat.com", "md5": "c50933ca2aa61e0fe2c43d46bb6b59cb" },"url":"https://warmcat.com/repo/openssl",
"f":3,
"items": [
{"schema":"libjg2-1",
"cid":"2f4b5400bcb9e60d5f9a5c29dad530e9",
"commit": {"type":"commit",
"time": 1516220853,
"time_ofs": 60,
"oid_tree": { "oid": "4caded3e1d2fc9b20a90ed133cf837b3d010f21a", "alias": []},
"oid":{ "oid": "825038d8c36075488922617e48fc4782afe871d1", "alias": []},
"msg": "TLSProxy::Proxy: don't waste time redirecting STDOUT and STDERR",
"sig_commit": { "git_time": { "time": 1516220853, "offset": 60 }, "name": "Richard Levitte", "email": "levitte@openssl.org", "md5": "b737120f0642a6a5c30c6291e6170c77" },
"sig_author": { "git_time": { "time": 1516220853, "offset": 60 }, "name": "Richard Levitte", "email": "levitte@openssl.org", "md5": "b737120f0642a6a5c30c6291e6170c77" }},
"body": "TLSProxy::Proxy: don't waste time redirecting STDOUT and STDERR\n\nOn Windows, it seems that doing so in a forked (pseudo-)process\nsometimes affects the parent, and thereby hides all the results that\nare supposed to be seen by the running test framework (the \u0022ok\u0022 and\n\u0022not ok\u0022 lines).\n\nIt turns out that our redirection isn't necessary, as the test\nframework seems to swallow it all in non-verbose mode anyway.\nIt's possible that we did need this at some point, but the framework\nhas undergone some refinement since then...\n\nReviewed-by: Rich Salz \u003crsalz@openssl.org\u003e\n(Merged from https://github.com/openssl/openssl/pull/5100)\n"
,
"diff": "diff --git a/util/perl/TLSProxy/Proxy.pm b/util/perl/TLSProxy/Proxy.pm\nindex a87675c..c29f440 100644\n--- a/util/perl/TLSProxy/Proxy.pm\n+++ b/util/perl/TLSProxy/Proxy.pm\n@@ -157,11 +157,6 @@ sub start\n \n $pid \u003d fork();\n if ($pid \u003d\u003d 0) {\n- if (!$self-\u003edebug) {\n- open(STDOUT, \u0022\u003e\u0022, File::Spec-\u003edevnull())\n- or die \u0022Failed to redirect stdout: $!\u0022;\n- open(STDERR, \u0022\u003e\u0026STDOUT\u0022);\n- }\n my $execcmd \u003d $self-\u003eexecute\n .\u0022 s_server -no_comp -rev -engine ossltest -accept \u0022\n .($self-\u003eserver_port)\n@@ -191,11 +186,6 @@ sub clientstart\n my ($self) \u003d shift;\n my $oldstdout;\n \n- if(!$self-\u003edebug) {\n- open DEVNULL, \u0022\u003e\u0022, File::Spec-\u003edevnull();\n- $oldstdout \u003d select(DEVNULL);\n- }\n-\n # Create the Proxy socket\n my $proxaddr \u003d $self-\u003eproxy_addr;\n $proxaddr \u003d~ s/[\u005c[\u005c]]//g; # Remove [ and ]\n@@ -217,11 +207,6 @@ sub clientstart\n if ($self-\u003eexecute) {\n my $pid \u003d fork();\n if ($pid \u003d\u003d 0) {\n- if (!$self-\u003edebug) {\n- open(STDOUT, \u0022\u003e\u0022, File::Spec-\u003edevnull())\n- or die \u0022Failed to redirect stdout: $!\u0022;\n- open(STDERR, \u0022\u003e\u0026STDOUT\u0022);\n- }\n my $echostr;\n if ($self-\u003ereneg()) {\n $echostr \u003d \u0022R\u0022;\n","s":{"c":1752058148,"u": 35585}}
],"g": 36250,"chitpc": 0,"ehitpc": 0,"indexed":0
,
"ab": 0, "si": 0, "db":0, "di":0, "sat":0, "lfc": "0000"}