{"schema":"libjg2-1", "vpath":"/git/", "avatar":"/git/avatar/", "alang":"", "gen_ut":1752660043, "reponame":"openssl", "desc":"OpenSSL", "owner": { "name": "Andy Green", "email": "andy@warmcat.com", "md5": "c50933ca2aa61e0fe2c43d46bb6b59cb" },"url":"https://warmcat.com/repo/openssl", "f":3, "items": [ {"schema":"libjg2-1", "cid":"4be0c9667e8b3d72a945f5b99d55ed90", "commit": {"type":"commit", "time": 1505425952, "time_ofs": 600, "oid_tree": { "oid": "f830cd1617479f2ac187d47b3426cbc21c4b71fa", "alias": []}, "oid":{ "oid": "6ffaf15d2363e782c6feeb8285a570986d03dd99", "alias": []}, "msg": "Remote unrequited casts Also use strndup instead of a malloc/memcpy pair.", "sig_commit": { "git_time": { "time": 1505425952, "offset": 600 }, "name": "Pauli", "email": "paul.dale@oracle.com", "md5": "4616f8cb80bd6ce4dab75d05e07cd125" }, "sig_author": { "git_time": { "time": 1505425952, "offset": 600 }, "name": "Pauli", "email": "paul.dale@oracle.com", "md5": "4616f8cb80bd6ce4dab75d05e07cd125" }}, "body": "Remote unrequited casts\nAlso use strndup instead of a malloc/memcpy pair.\n\nReviewed-by: Rich Salz \u003crsalz@openssl.org\u003e\n(Merged from https://github.com/openssl/openssl/pull/4372)\n" , "diff": "diff --git a/crypto/x509/by_dir.c b/crypto/x509/by_dir.c\nindex e1a09cb..03492ac 100644\n--- a/crypto/x509/by_dir.c\n+++ b/crypto/x509/by_dir.c\n@@ -170,8 +170,7 @@ static int add_cert_dir(BY_DIR *ctx, const char *dir, int type)\n continue;\n for (j \u003d 0; j \u003c sk_BY_DIR_ENTRY_num(ctx-\u003edirs); j++) {\n ent \u003d sk_BY_DIR_ENTRY_value(ctx-\u003edirs, j);\n- if (strlen(ent-\u003edir) \u003d\u003d (size_t)len \u0026\u0026\n- strncmp(ent-\u003edir, ss, (unsigned int)len) \u003d\u003d 0)\n+ if (strlen(ent-\u003edir) \u003d\u003d len \u0026\u0026 strncmp(ent-\u003edir, ss, len) \u003d\u003d 0)\n break;\n }\n if (j \u003c sk_BY_DIR_ENTRY_num(ctx-\u003edirs))\n@@ -188,13 +187,11 @@ static int add_cert_dir(BY_DIR *ctx, const char *dir, int type)\n return 0;\n ent-\u003edir_type \u003d type;\n ent-\u003ehashes \u003d sk_BY_DIR_HASH_new(by_dir_hash_cmp);\n- ent-\u003edir \u003d OPENSSL_malloc((unsigned int)len + 1);\n+ ent-\u003edir \u003d OPENSSL_strndup(ss, len);\n if (ent-\u003edir \u003d\u003d NULL || ent-\u003ehashes \u003d\u003d NULL) {\n by_dir_entry_free(ent);\n return 0;\n }\n- strncpy(ent-\u003edir, ss, (unsigned int)len);\n- ent-\u003edir[len] \u003d '\u005c0';\n if (!sk_BY_DIR_ENTRY_push(ctx-\u003edirs, ent)) {\n by_dir_entry_free(ent);\n return 0;\n","s":{"c":1752660043,"u": 40709}} ],"g": 41577,"chitpc": 0,"ehitpc": 0,"indexed":0 , "ab": 0, "si": 0, "db":0, "di":0, "sat":0, "lfc": "0000"}