{"schema":"libjg2-1", "vpath":"/git/", "avatar":"/git/avatar/", "alang":"", "gen_ut":1756842864, "reponame":"openssl", "desc":"OpenSSL", "owner": { "name": "Andy Green", "email": "andy@warmcat.com", "md5": "c50933ca2aa61e0fe2c43d46bb6b59cb" },"url":"https://warmcat.com/repo/openssl", "f":3, "items": [ {"schema":"libjg2-1", "cid":"d7341d078955a0b81ac6a5a4481593de", "commit": {"type":"commit", "time": 1457052250, "time_ofs": 18446744073709551316, "oid_tree": { "oid": "6bb34b27543d1e896aef0ac4d91447d0c9f41c1e", "alias": []}, "oid":{ "oid": "5e04cfdef345c69a4bb04db81766702f994172f3", "alias": []}, "msg": "GH769: Reuse strndup()", "sig_commit": { "git_time": { "time": 1457052250, "offset": -300 }, "name": "Rich Salz", "email": "rsalz@akamai.com", "md5": "825a7f3ef767f852ea1717d3b4a10cd3" }, "sig_author": { "git_time": { "time": 1456822095, "offset": 180 }, "name": "Dmitry-Me", "email": "wipedout@yandex.ru", "md5": "e2cef525cef5d7b0078f33b707e30c69" }}, "body": "GH769: Reuse strndup()\n\nReviewed-by: Matt Caswell \u003cmatt@openssl.org\u003e\nSigned-off-by: Rich Salz \u003crsalz@akamai.com\u003e\n" , "diff": "diff --git a/crypto/x509v3/v3_alt.c b/crypto/x509v3/v3_alt.c\nindex b2914ee..4b143f9 100644\n--- a/crypto/x509v3/v3_alt.c\n+++ b/crypto/x509v3/v3_alt.c\n@@ -577,11 +577,9 @@ static int do_othername(GENERAL_NAME *gen, char *value, X509V3_CTX *ctx)\n if ((gen-\u003ed.otherName-\u003evalue \u003d ASN1_generate_v3(p + 1, ctx)) \u003d\u003d NULL)\n return 0;\n objlen \u003d p - value;\n- objtmp \u003d OPENSSL_malloc(objlen + 1);\n+ objtmp \u003d OPENSSL_strndup(value, objlen);\n if (objtmp \u003d\u003d NULL)\n return 0;\n- strncpy(objtmp, value, objlen);\n- objtmp[objlen] \u003d 0;\n gen-\u003ed.otherName-\u003etype_id \u003d OBJ_txt2obj(objtmp, 0);\n OPENSSL_free(objtmp);\n if (!gen-\u003ed.otherName-\u003etype_id)\ndiff --git a/crypto/x509v3/v3_info.c b/crypto/x509v3/v3_info.c\nindex a7ea19a..16e25fa 100644\n--- a/crypto/x509v3/v3_info.c\n+++ b/crypto/x509v3/v3_info.c\n@@ -177,13 +177,11 @@ static AUTHORITY_INFO_ACCESS *v2i_AUTHORITY_INFO_ACCESS(X509V3_EXT_METHOD\n ctmp.value \u003d cnf-\u003evalue;\n if (!v2i_GENERAL_NAME_ex(acc-\u003elocation, method, ctx, \u0026ctmp, 0))\n goto err;\n- if ((objtmp \u003d OPENSSL_malloc(objlen + 1)) \u003d\u003d NULL) {\n+ if ((objtmp \u003d OPENSSL_strndup(cnf-\u003ename, objlen)) \u003d\u003d NULL) {\n X509V3err(X509V3_F_V2I_AUTHORITY_INFO_ACCESS,\n ERR_R_MALLOC_FAILURE);\n goto err;\n }\n- strncpy(objtmp, cnf-\u003ename, objlen);\n- objtmp[objlen] \u003d 0;\n acc-\u003emethod \u003d OBJ_txt2obj(objtmp, 0);\n if (!acc-\u003emethod) {\n X509V3err(X509V3_F_V2I_AUTHORITY_INFO_ACCESS,\n","s":{"c":1756842864,"u": 2714}} ],"g": 3998,"chitpc": 0,"ehitpc": 0,"indexed":0 , "ab": 0, "si": 0, "db":0, "di":0, "sat":0, "lfc": "0000"}