{"schema":"libjg2-1", "vpath":"/git/", "avatar":"/git/avatar/", "alang":"", "gen_ut":1752063227, "reponame":"openssl", "desc":"OpenSSL", "owner": { "name": "Andy Green", "email": "andy@warmcat.com", "md5": "c50933ca2aa61e0fe2c43d46bb6b59cb" },"url":"https://warmcat.com/repo/openssl", "f":3, "items": [ {"schema":"libjg2-1", "cid":"7bda5f2939310f6021bf2567da896454", "commit": {"type":"commit", "time": 1495443995, "time_ofs": 120, "oid_tree": { "oid": "fe53e6a649b5f9937beca06115727d75cdaf3341", "alias": []}, "oid":{ "oid": "fee423bb68869de02fceaceefbc847e98213574b", "alias": []}, "msg": "Fix the mem_sec \u0022small arena\u0022", "sig_commit": { "git_time": { "time": 1495443995, "offset": 120 }, "name": "Andy Polyakov", "email": "appro@openssl.org", "md5": "50bd64fa2a792cbbf679fa16213a3b2a" }, "sig_author": { "git_time": { "time": 1495376466, "offset": -240 }, "name": "Todd Short", "email": "tshort@akamai.com", "md5": "e0436a4477f604d3a4d03268d03fb577" }}, "body": "Fix the mem_sec \u0022small arena\u0022\n\nFix the small arena test to just check for the symptom of the infinite\nloop (i.e. initialized set on failure), rather than the actual infinite\nloop. This avoids some valgrind errors.\n\nReviewed-by: Rich Salz \u003crsalz@openssl.org\u003e\nReviewed-by: Andy Polyakov \u003cappro@openssl.org\u003e\n(Merged from https://github.com/openssl/openssl/pull/3512)\n" , "diff": "diff --git a/test/secmemtest.c b/test/secmemtest.c\nindex cb7d1ec..c7d4fe7 100644\n--- a/test/secmemtest.c\n+++ b/test/secmemtest.c\n@@ -68,12 +68,15 @@ static int test_sec_mem(void)\n TEST_ptr_null(OPENSSL_secure_malloc((size_t)-1));\n TEST_true(CRYPTO_secure_malloc_done());\n \n- TEST_info(\u0022Possible infinite loop: small arena\u0022);\n- if (!TEST_false(CRYPTO_secure_malloc_init(16, 16)))\n+ /*\n+ * If init fails, then initialized should be false, if not, this\n+ * could cause an infinite loop secure_malloc, but we don't test it\n+ */\n+ if (TEST_false(CRYPTO_secure_malloc_init(16, 16)) \u0026\u0026\n+ !TEST_false(CRYPTO_secure_malloc_initialized())) {\n+ TEST_true(CRYPTO_secure_malloc_done());\n goto end;\n- TEST_false(CRYPTO_secure_malloc_initialized());\n- TEST_ptr_null(OPENSSL_secure_malloc((size_t)-1));\n- TEST_true(CRYPTO_secure_malloc_done());\n+ }\n \n /*-\n * There was also a possible infinite loop when the number of\n@@ -105,7 +108,7 @@ static int test_sec_mem(void)\n TEST_true(CRYPTO_secure_malloc_done());\n }\n # endif\n- \n+\n /* this can complete - it was not really secure */\n testresult \u003d 1;\n end:\n","s":{"c":1752063227,"u": 49869}} ],"g": 51358,"chitpc": 0,"ehitpc": 0,"indexed":0 , "ab": 0, "si": 0, "db":0, "di":0, "sat":0, "lfc": "0000"}